Skip to content

Commit

Permalink
fixes nanomsg#1526 NNG_USE_CLOCKID Bug?
Browse files Browse the repository at this point in the history
This makes CLOCK_MONOTONIC the default (as it should have been)
for platforms that have it defined, except for Apple platforms which lack
support for using anything other than the real time clock with condition
variables.  (And unfortunately silently ignore attempts to do otherwise.)
  • Loading branch information
gdamore authored and JaylinYu committed Nov 29, 2021
1 parent bd9355e commit fc84d8a
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 15 deletions.
30 changes: 15 additions & 15 deletions src/platform/posix/posix_config.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2019 Staysail Systems, Inc. <[email protected]>
// Copyright 2021 Staysail Systems, Inc. <[email protected]>
//
// This software is supplied under the terms of the MIT License, a
// copy of which should be located in the distribution where this
Expand All @@ -20,11 +20,14 @@
// the system lacks clock_gettime, then it will choose this automatically.
// This value may be ignored on platforms that don't use POSIX clocks.
//
// #define NNG_USE_CLOCKID
// #define NNG_USE_CLOCKID CLOCK_MONOTONIC
// This macro may be defined to a different clock id (see
// clock_gettime()). By default we use CLOCK_MONOTONIC if it exists,
// or CLOCK_REALTIME otherwise. This is ignored if NNG_USE_GETTIMEOFDAY
// is defined. Platforms that don't use POSIX clocks will probably
// clock_gettime()). By default, we use CLOCK_MONOTONIC if it exists,
// or CLOCK_REALTIME otherwise. (Except for macOS, which does not have
// a functional pthread_condattr_setclock().)
//
// This is ignored if NNG_USE_GETTIMEOFDAY is defined.
// Platforms that don't use POSIX clocks will probably
// ignore any setting here.
//
// #define NNG_HAVE_BACKTRACE
Expand Down Expand Up @@ -61,21 +64,18 @@
#endif
#endif

#ifndef NNG_USE_CLOCKID
#if defined(__APPLE__)
#define NNG_USE_CLOCKID CLOCK_REALTIME
#ifndef CLOCK_REALTIME
#define NNG_USE_GETTIMEOFDAY
#elif !defined(NNG_USE_CLOCKID)
#elif defined(CLOCK_MONOTONIC)
#define NNG_USE_CLOCKID CLOCK_MONOTONIC
#else
#elif defined(CLOCK_REALTIME)
#define NNG_USE_CLOCKID CLOCK_REALTIME
#endif // CLOCK_REALTIME

#if defined(NNG_HAVE_KQUEUE)
// pass
#else
// fallback to poll(2)
#define NNG_USE_POSIX_POLLQ_POLL 1
#define NNG_USE_GETTIMEOFDAY
#endif
#endif

#define NNG_USE_POSIX_RESOLV_GAI 1

#endif // NNG_PLATFORM_POSIX
4 changes: 4 additions & 0 deletions src/testing/marry.c
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,10 @@ nuts_marry_ex(
replace_port_zero(url, addr, port);
url = addr;
}
if (((rv = nng_setopt_ms(s2, NNG_OPT_RECONNMINT, 10)) != 0) ||
((rv = nng_setopt_ms(s2, NNG_OPT_RECONNMAXT, 10)) != 0)) {
goto done;
}
if ((rv = nng_dial(s2, url, NULL, 0)) != 0) {
goto done;
}
Expand Down

0 comments on commit fc84d8a

Please sign in to comment.