Sync with NNG 1.10 stable #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 9d0b023b39aae37adb6e5cb1a2b926777ffd2023)
(cherry picked from commit 3cfd6ab21bfb8b02fde1e976fc0bf50bf729c8ab)
This bug was already fixed in the main branch.
This does not fully mark them in the headers, to avoid complicating test suites and such, for now.
We forgot to do this for 1.9.0, which incorrectly claims to be 1.8.0.
It turns out that for now this results in early wakeups, due to another bug in the aio framework. But when that bug is fixed, this bug will lead to hangs when redialing. (cherry picked from commit 2dfb99506142f2d59bcc0e0fa7db6b19a3c75d43)
These functions were added in the main branch for NNG 2.0, and we add them here to facilitate converting any code that happened to use the options (`NNG_OPT_PROTO`, `NNG_OPT_PROTONAME`, `NNG_OPT_PEER`, `NNG_OPT_PEERNAME`, and `NNG_OPT_RAW`. Its unlikely that many applications need this, but providing these as a transition aid may help applications start adopting new APIs now.
These are new functions that replace `NNG_OPT_SUBSCRIBE` and `NNG_OPT_UNSUBSCRIBE`. They are provided here as a transition aid before those options are removed in NNG 2.0. Signed-off-by: jaylin <[email protected]>
This hopefully addresses a long standing bug with Windows IPC sometimes hanging on shut down.
This fixes a possible failure condition on teardown.
Actually this test appears to be broken everywhere, and the only reason it ever worked is that we took > 50 ms to context switch. (cherry picked from commit 1a4d71cdd4ff80bb79d842c081296c298e7b2295)
fix conflicts by jaylin These are the 2.0 equivalent versions of nng_send_aio and nng_recv_aio. The old names are preserved as aliases for the new. Applications can start adopting these with this release, even before 2.0 is ready. Signed-off-by: jaylin <[email protected]>
…_get_url fix conflicts with nng_dialer_off This is meant to help applications start adopting new interfaces before converting to NNG 2.0 Signed-off-by: jaylin <[email protected]>
This does not impact the core project, but merely updates tools used for publishing docs on the website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.