Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GetCustomAttributes #865

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Add GetCurrent function to CLR_RT_AttributeEnumerator
  • Fix bug in CLR_RT_AttributeEnumerator::Initialize

Motivation and Context

How Has This Been Tested?

  • CustomAttributes sample from samples repo.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels Sep 27, 2018
@nfbot
Copy link
Member

nfbot commented Sep 27, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Add GetCurrent function to CLR_RT_AttributeEnumerator
- Fix bug in CLR_RT_AttributeEnumerator::Initialize
- Add code to support nanoframework/CoreLibrary#27

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes force-pushed the add-support-mscorlib-pr27 branch from 86614ca to e3762c9 Compare September 28, 2018 17:09
@josesimoes josesimoes merged commit 13eff35 into nanoframework:develop Sep 28, 2018
@josesimoes josesimoes deleted the add-support-mscorlib-pr27 branch September 28, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants