Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ToString for doubles and floats #815

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Aug 8, 2018

Description

Motivation and Context

  • The output was wrong when specifying a number of decimal places

⚠️ for completly fixing the issue nanoframework/CoreLibrary#22 needs to be released ⚠️

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Aug 8, 2018
@nfbot
Copy link
Member

nfbot commented Aug 8, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- The output was wrong when specifying a number of decimal places

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes force-pushed the fix-tostring-double-float branch from a5d3275 to b5fa10b Compare August 8, 2018 11:28
@josesimoes josesimoes merged commit a985e31 into nanoframework:develop Aug 8, 2018
@josesimoes josesimoes deleted the fix-tostring-double-float branch August 8, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants