Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UpdateTime from Engine #698

Merged

Conversation

josesimoes
Copy link
Member

Description

  • Remove UpdateTime from Engine
  • Replace with direct call to HAL_Time_CurrentTime()

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

- This call is now irrelevant as it's was merely updating a var
- Working towards nanoframework/Home#112

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such labels May 24, 2018
@nfbot
Copy link
Member

nfbot commented May 24, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 52bdcac into nanoframework:develop May 24, 2018
@josesimoes josesimoes deleted the improvements-execution-update-timer branch May 24, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants