Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements with timers from ChibiOS API #694

Merged
merged 1 commit into from
May 18, 2018
Merged

Improvements with timers from ChibiOS API #694

merged 1 commit into from
May 18, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Remove call to stop a timer before setting it (no need as the API already does that)
  • Add dummy var to timer callback argument, instead of NULL, to make sure that the API and compiler are absolutly happy with it
  • Add ChibiOS Syslock and unlock to time event callback

Motivation and Context

  • Improves usage of ChibiOS timers and removes unnecessary calls

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@josesimoes
Improvements with timers from ChibiOS API
1263deb 
- Remove call to stop a timer before setting it (no need as the API already does that)
- Add dummy var to timer callback argument, instead of NULL, to make sure that the API and compiler are absolutly happy with it
- Add ChibiOS Syslock and unlock to time event callback

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels May 18, 2018
@nfbot
Copy link
Member

nfbot commented May 18, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 0d5c0ce into nanoframework:develop May 18, 2018
@josesimoes josesimoes deleted the improvements-with-chibios-timers branch May 18, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot