Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for ESP32 #645

Merged
merged 3 commits into from
Mar 13, 2018
Merged

Various fixes for ESP32 #645

merged 3 commits into from
Mar 13, 2018

Conversation

AdrianSoundy
Copy link
Member

Description

  • Add Pwm, Adc and Network into Appveyor builds.
  • Disable logging from IDF which caused a 2nd deploy from Visual Studio to fail.
  • Add missing file in Makelist.txt for network builds
  • Fix to GPIO where some pins not working as gpio was the alternate function. Calling IDF config instead of separate methods fixes issue as also assigns the correct function to pin.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy <adriansoundy.gmail.com>

@AdrianSoundy
Various fixes for ESP32
5e85bdc 
Add Pwm, Adc and Network into Appveyor builds
Disable logging from IDF which caused a 2nd deploy to fail
Add missing file in Makelist for network builds
Fix to GPIO where some pins not working as gpio is alternate function. Calling config instead of separate methods also assigns the correct function to pin.
@nfbot
Copy link
Member

nfbot commented Mar 13, 2018

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added the Series: ESP32 Everything related specifically with ESP32 series targets label Mar 13, 2018
josesimoes
josesimoes approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit 7a1b881 into nanoframework:develop Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees

@AdrianSoundy AdrianSoundy

Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdrianSoundy @nfbot @josesimoes