Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reboot command execution #612

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Improve reboot command execution #612

merged 1 commit into from
Feb 14, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Add new constants to Monitor_Reboot to follow managed debugger
  • Remove reboot constants from execution engine struct
  • Rework reboot macros
  • Update code accordingly

Motivation and Context

  • Improves usability of reboot command
  • Solves exceptions when trying to deleted execution engine instance when that is not possible
  • Required for debugger lib >= 0.5.0-preview065

How Has This Been Tested?

  • Debugger library WPF test app

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Improve reboot command execution
4750591 
- Add new constants to Monitor_Reboot to follow managed debugger
- Remove reboot constants from execution engine struct
- Rework reboot macros
- Update code accordingly
- Required for debugger lib >= 0.5.0-preview065

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets labels Feb 14, 2018
@nfbot
Copy link
Member

nfbot commented Feb 14, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit aff1f8b into nanoframework:develop Feb 14, 2018
@josesimoes josesimoes deleted the work-reboot-command-execution branch February 14, 2018 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Area: Targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot