Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serial com Store() delay #605

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Feb 9, 2018

Description

  • Correct code for events handling that was causing a delay equal to the timeout when storing data in the Tx stream

Motivation and Context

How Has This Been Tested?

  • SerialComm app from samples repo

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

- Correct code for events handling that was causing a delay equal to the timeout when storing data in the Tx stream

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Feb 9, 2018
@nfbot
Copy link
Member

nfbot commented Feb 9, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

@AdrianSoundy I went and try to fix this in the ESP32 code but it seems that the execution events are not being used in the Store() and Read() calls there...

@josesimoes josesimoes merged commit b7ceee3 into nanoframework:develop Feb 9, 2018
@josesimoes josesimoes deleted the fix-serial-store-delay branch February 9, 2018 19:55
@ghost
Copy link

ghost commented Feb 9, 2018

This does not fix the issue in the description but hopefully this one instead : nanoframework/Home#283
😉

@AdrianSoundy
Copy link
Member

The esp32 serial driver still needs updating to use evenrwaits for the read & store. Will update once finished with in tial network stuff.

@ghost
Copy link

ghost commented Feb 10, 2018

The changes here do not fix the issue. I am reopening it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gpio events do not behave as expected
3 participants