Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inclusion of target source file for serial API #587

Merged
merged 2 commits into from
Jan 25, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Fix inclusion of target source file for serial API

Motivation and Context

  • The build was failing for targets that have the serial stuff setup and the CMake option is OFF. The cpp file was always in the build but the header couldn't be found because the include directory was only there when the option was ON.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

- The build was failing for targets that have the serial stuff setup and the CMake option is OFF

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Jan 25, 2018
@nfbot
Copy link
Member

nfbot commented Jan 25, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit b11dd84 into nanoframework:develop Jan 25, 2018
@josesimoes josesimoes deleted the fix-serial-target-sources branch January 25, 2018 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants