Include community board in select clause for I2C #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compile breaks because of undeclared vars in I2C version for F4-Series boards. For this series version 1 has to be forced to use at two places in the cmake module. By adding the community board string to the distinct list of F4 boards that select the correct version for I2C the compiler was happy and builds successfully. Signed-off-by: piwi1263 <[email protected]>
|
Hi @piwi1263, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
ghost
approved these changes
Jan 7, 2018
ghost
merged commit 
10 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The compile breaks because of undeclared vars in I2C version for F4-Series boards.
Motivation and Context
For the F4-Series version 1 has to be forced to use at two places in the cmake module.
How Has This Been Tested?
By adding the community board string to the distinct list of F4 boards that select the correct version for I2C the compiler was happy and builds successfully.
Screenshots
Types of changes
Checklist:
Signed-off-by: piwi1263 [email protected]