Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'obvious fix' rule #53

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Added 'obvious fix' rule #53

merged 1 commit into from
Jan 13, 2017

Conversation

cw2
Copy link
Contributor

@cw2 cw2 commented Jan 11, 2017

Relates to #46.

@cw2 cw2 requested a review from josesimoes January 11, 2017 22:31
@cw2
Copy link
Contributor Author

cw2 commented Jan 11, 2017

I have created a trivial desktop application (.NET + octokit) that can be used to set github 'status' check status ;). I think a human intervention is still necessary, to verify the signoff user name and whether an 'obvious fix' rule is correct (if stated in the comment).

@josesimoes
Copy link
Member

Not sure were to manually check the signed-off-by check for this to work...

@cw2
Copy link
Contributor Author

cw2 commented Jan 11, 2017

Well, you need an awesome nano status update tool :)

@josesimoes josesimoes merged commit dc6bbcc into nanoframework:dev-alpha Jan 13, 2017
@cw2 cw2 deleted the doc-obvious-fix branch January 13, 2017 10:46
@ghost ghost mentioned this pull request May 15, 2017
josesimoes pushed a commit that referenced this pull request May 15, 2017
This is related to the New try on Windows.Devices.Gpio PR #53

Signed-off-by: Christophe Gerbier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants