Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for TimeSpan.ToString() #505

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

josesimoes
Copy link
Member

Description

Add code to implement TimeSpan.ToString().

Motivation and Context

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets labels Sep 15, 2017
@nfbot
Copy link
Member

nfbot commented Sep 15, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@ghost
Copy link

ghost commented Sep 15, 2017

Aren't the "SafePrintf***()" methods already existing with another name somewhere else ?

@josesimoes
Copy link
Member Author

@MikroBusNet almost... they look the same but these Safe** use reference parameters instead.

@josesimoes josesimoes merged commit 2838a22 into nanoframework:master Sep 15, 2017
@josesimoes josesimoes deleted the resolves-122 branch September 15, 2017 13:41
@josesimoes
Copy link
Member Author

@MikroBusNet I've look harder and you are correct: there are CLR_Safe**** but just not implemented.
I'm working on it now. Thank you very much for pointing this! 👍 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants