Spi f7 #480
Merged
Spi f7 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 1, 2017 09:34
Backup of changes for SPI with F7 MCU Signed-off-by: Christophe Gerbier <[email protected]>
Still not working as expected, however. Signed-off-by: Christophe Gerbier <[email protected]>
|
Hi @MikroBusNet, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
in nf-overlay Signed-off-by: Christophe Gerbier <[email protected]>
Know that your original comments are not erased, they remain at the top. The hint text is added afterwards. 😉 |
|
Ok. Perhaps I did not notice. I will see with my next PR ;) Anyway, Travis is not happy once again. Does it have the SWO option ? |
|
Travis doesn't have SWO enabled because that's a feature typically used during debug. Plus it increases RAM and FLASH usage. It seems that you've left some SWO call in SPI. That shouldn't be there... |
To please Travis Signed-off-by: Christophe Gerbier <[email protected]>
josesimoes
added
Area: Interpreter
josesimoes
approved these changes
Sep 2, 2017
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added specific code for STM32F7 MCU
Motivation and Context
I am very motivated and the context is good as well ;)
How Has This Been Tested? (if applicable)
Result not 100% accurate on Nucleo-F746ZG so far.
Note : too bad that the comments erased my initial comment :(