Fix Quail nanoBooter main code #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked code to comply with latest workflow. Signed-off-by: Christophe Gerbier <[email protected]>
|
Hi @MikroBusNet, I'm nanoFramework bot. Everything seems to be in order. |
|
@MikroBusNet out of curiosity: Why have you disable USB? |
|
Because there is no user interaction in my booter's code : execution is only lasting a few seconds before it launches automatically the CLR. So there was no real need for communication at that stage. Do you want me to re-add that USB code ? |
ghost
deleted the
|
In the current state that (remaining in booter just a short time) will happen IF there is a valid nanoCLR image. If not, or if the booter has... booted... to perform an update it will remain there and will need the USB device active. So yes, please, enable USB just like on any other board. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked code to comply with latest workflow.
This fixes #178 .
Signed-off-by: Christophe Gerbier [email protected]