Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileStream memory leak #2160

Merged
merged 6 commits into from
Nov 27, 2021
Merged

Fix FileStream memory leak #2160

merged 6 commits into from
Nov 27, 2021

Conversation

alberk8
Copy link
Contributor

@alberk8 alberk8 commented Nov 27, 2021

Description

  1. Remove the vfsPath platform_malloc.
  2. Remove check for vfsPath == NULL;

Motivation and Context

How Has This Been Tested?

loop 100 times.
https://github.com/alberk8/nanoFramework-SDCard-Test/tree/main/nanoFrameworkSDCard

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Nov 27, 2021

@alberk8 there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click alberk8#2, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…80a-97f6-4576-b3b9-057d7d053917

Code style fixes for nanoframework/nf-interpreter PR#2160
@josesimoes josesimoes added the Platform: ESP32 Everything related specifically with ESP32 platform label Nov 27, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job chasing this down!
I've added a missing check for succesfulll malloc and comments stressing the need to free memory by the caller.

It's not perfect, but will get the job done.

@josesimoes josesimoes enabled auto-merge (squash) November 27, 2021 08:47
Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Nov 27, 2021

@alberk8 there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click alberk8#3, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…a90-7a74-4eed-80f1-3a642abf1fa1

Code style fixes for nanoframework/nf-interpreter PR#2160
auto-merge was automatically disabled November 27, 2021 08:51

Head branch was pushed to by a user without write access

@josesimoes josesimoes merged commit cf22b14 into nanoframework:develop Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: ESP32 Everything related specifically with ESP32 platform Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDCard native library leaking memory
3 participants