Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new event category EVENT_HIGH_RESOLUTION_TIMER #2108

Conversation

Henrik98
Copy link
Contributor

@Henrik98 Henrik98 commented Oct 19, 2021

Description

  • Adding new event category EVENT_HIGH_RESOLUTION_TIMER.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…targets\ESP32\_nanoCLR\nanoFramework.Hardware.ESP32\nanoFramework_hardware_esp32_native_Hardware_Esp32_HighResTimer.cpp

Signed-off-by: Henrik <[email protected]>
Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Oct 19, 2021

@Henrik98 there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click Henrik98#1, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

@josesimoes josesimoes changed the title Adding new event category EVENT_HIGH_RESOLUTION_TIMER and use it in \… Adding new event category EVENT_HIGH_RESOLUTION_TIMER Oct 19, 2021
@josesimoes
Copy link
Member

@Henrik98 getting there!

  1. Please merge the PR with the code style fixes.
  2. I've edited the PR to have a shorter and concise title (this is what shows on the change log) PR titles should be short and descriptive.
  3. I've also edited the description. Added description of the changes (in this case they are really obvious and already in the tile, yet...) Also about the change type to enhancement. Despite the overall goal is to ultimately solve that bug of the "wrong" event code being used, this particular PR is just adding the new event category. So it's not a bug fix per se.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…61e-77c8-4fb2-9dd4-ef3e59f5bcfb

Code style fixes for nanoframework/nf-interpreter PR#2108
auto-merge was automatically disabled October 19, 2021 20:33

Head branch was pushed to by a user without write access

@Henrik98
Copy link
Contributor Author

Henrik98 commented Oct 19, 2021

Hi @josesimoes ,
I've merged code style changes into my branch do I have to do anything more?
I see "This branch is out-of-date with the base branch" should I press "Update Branch"?

@josesimoes
Copy link
Member

Hi @josesimoes , I've merged code style changes into my branch do I have to do anything more? I see "This branch is out-of-date with the base branch" should I press "Update Branch"?

@Henrik98 all good! Build run successfully, so this is going to be merged.

@josesimoes josesimoes enabled auto-merge (squash) October 20, 2021 07:13
@josesimoes josesimoes merged commit 5f3213f into nanoframework:develop Oct 20, 2021
@nfbot
Copy link
Member

nfbot commented Oct 20, 2021

@Henrik98 thank you again for your contribution! 🙏😄

.NET nanoFramework it's all about community involvement and no contribution is too small.
We would like to invite you to join the project Contributors list.

Please edit it and add an entry with your GitHub user in the appropriate location (names sorted alphabetically):

  <tr>
    <td><img src="https://github.com/Henrik98.png?size=50&" height="50" width="50" ></td>
    <td><a href="https://github.com/Henrik98"></a></td>
  </tr>

(feel free to adjust your name, if it's not correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Esp32.HighResEventListener wrongly uses EventCategory.Custom
3 participants