-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simpler top-level cmakelists #2083
Simpler top-level cmakelists #2083
Conversation
Removed most of the custom RTOS & target logic. Could remove ESP difference when ESP library updated to 4.x
Hi @doingnz, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
fix text in status message. Co-authored-by: José Simões <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@josesimoes I'm not sure how nfbot is deciding when to apply the |
@nightlark criteria for adding invalid label is for PRs that where closed without being merged. This one must have been a glitch resulting from the order the git events where processed. The code processing these hasn't been changed for months now. Actually I've just found one. We'll look into this to understand why and fix it. |
- Improvement to fix reported issue of miss labelling a PR with invalid when it's not. nanoframework/nf-interpreter#2083 (comment)
Description
Removed most of the custom RTOS & target logic as the approach encouraged additional script for each additional target.
This PR does not change the logic for the two ESP targets other than to use the same named CMake variables for the RTOS and Target folders to show how close it is to being the same as the other targets. Given the ESP targets are being reworked for the update to 4.x, I have left that change to the person doing the ESP update to remove ESP difference.
Motivation and Context
Ideally there would be no RTOS or TARGET specific logic in this top-level CMakeLists.txt to aim for reduced responsibility and remove chance of unexpected interactions when new platforms added. its purpose should be restricted to check a target exists and validate high level shared options common to all nanoFramework targets. It also manages the selection of the standard target or community target.
With this change, a new ${RTOS} & ${TARGET} will be found simply by creation of the folders under /targets. i.e. /targets/${RTOS}/${TARGET}
How Has This Been Tested?
Confirmed can build ESP32 and STM32 targets.
Screenshots
Types of changes
Checklist: