Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call to set native pin configuration #2072

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Remove wrong call to check for class pointer on static call.
  • Tidy up code.

Motivation and Context

  • Fixes issue with setting GPIO0.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Sep 23, 2021

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added the Series: ESP32 Everything related specifically with ESP32 series targets label Sep 23, 2021
@josesimoes josesimoes changed the title Fix call to setting native pin configuration Fix call to set native pin configuration Sep 23, 2021
@josesimoes
Copy link
Member Author

cc @Ellerbach @ikivanc

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks for the fix.

@josesimoes josesimoes merged commit 01916a7 into develop Sep 23, 2021
@josesimoes josesimoes deleted the josesimoes-patch-1 branch September 23, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants