Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in SPIFFS #2071

Merged
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Brought SPIFFS config up to date.
  • Add support for second SPIFFS instance.
  • Rework ORGPAL3 to use 2 SPIFFS instances.
  • Improve Windows_Storage_StorageFolder to handle multiple SPIFFS instances.
  • Update SPIFFS code to use specific hal calls when multiple instances are present.
  • Improvements and fixes with various functions in StorageFolder class.
    • Add initializers to several structs.
    • Add checks for operations before attempting to call them unnecessarily.
    • Change order of check for internal storage to improve code.
  • Update spiffs implementation for ST_STM32F769I_DISCOVERY.
  • Revert code formatting changes to easily compare with template config file.

Motivation and Context

  • Bring SPIFFS up to date.
  • Add support for second SPIFFS instance on ORGPAL3.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Sep 22, 2021

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

cc @gligorov

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Series: STM32xx Everything related specifically with STM32 targets labels Sep 22, 2021
Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Sep 22, 2021

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click josesimoes#1, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…c2e-691c-4b8c-84b0-f03de4d86ae4

Code style fixes for nanoframework/nf-interpreter PR#2071
@josesimoes josesimoes merged commit f5d0262 into nanoframework:develop Sep 22, 2021
@josesimoes josesimoes deleted the add-2nd-spiff-drive-orgpal3 branch September 22, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Series: STM32xx Everything related specifically with STM32 targets Type: bug Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants