Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make available enough memory for SSL #1986

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Make available enough memory for SSL #1986

merged 1 commit into from
Jul 18, 2021

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Jul 18, 2021

Description

With IDF release v3.3.5 there wasn't enough free ram of size 16717 to allocated 2nd in/out buffer required by SSL.
Currently biggest space was 16505 which was ~200 bytes short

This was only relevant to ESP32 modules without PSRAM

This was done by reducing managed heap to 90K

Also renamed WROOM_32_V3 target to WROOM_32_V3_BLE as discussed and to match repo readme.md

Motivation and Context

How Has This Been Tested?

Run sample SSL client as test

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AdrianSoundy AdrianSoundy self-assigned this Jul 18, 2021
@AdrianSoundy AdrianSoundy added the Series: ESP32 Everything related specifically with ESP32 series targets label Jul 18, 2021
@AdrianSoundy AdrianSoundy merged commit 1f8e82b into nanoframework:develop Jul 18, 2021
@AdrianSoundy AdrianSoundy deleted the Network_v3.3.5 branch July 18, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 SSL broken in 1.6.5-preview.455
2 participants