Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugger discovery #1969

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Replace Events_WaitForEvents with PLATFORM_DELAY.

Motivation and Context

  • Resolves issues with debugger discovery on less performant platforms. The call to wait events was bailing out because of UART activity (which triggered an early return) or when the time base isn't yet setup. On these situations the previous fix wasn't working and the UART was being completly flooded with ping packets.

How Has This Been Tested?

  • Deployment tests with various apps.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Jun 30, 2021
- Replace Events_WaitForEvents with PLATFORM_DELAY.
@josesimoes josesimoes force-pushed the fix-debugger-discovery branch from e8f041c to b9108a8 Compare June 30, 2021 17:39
@josesimoes josesimoes merged commit c4055a4 into nanoframework:develop Jun 30, 2021
@josesimoes josesimoes deleted the fix-debugger-discovery branch June 30, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants