Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WiFi Connect #1952

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Fix WiFi Connect #1952

merged 3 commits into from
Jun 14, 2021

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Jun 14, 2021

Description

The original code didn't take in to account of the call being async. It only started the WiFi connect.
Added logic to wait for the station to be connected or a failure.

Added new events to nanClr to allow for waitEvents to be used.

Also fixed another problem if you used option of no Auto connect. It would disable the WiFi as the Auto_COnnect option includes the Enable flag.

Motivation and Context

How Has This Been Tested?

Tested with WiFi sample plus some other test cases

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@AdrianSoundy AdrianSoundy added Series: ESP32 Everything related specifically with ESP32 series targets Status: DONE labels Jun 14, 2021
Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Jun 14, 2021

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click https://github.com/AdrianSoundy/nf-interpreter/pull/30, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…7-a74c-4a81-a0bb-0fe13104768d' into wifi_test
@AdrianSoundy AdrianSoundy merged commit 911a364 into nanoframework:develop Jun 14, 2021
@AdrianSoundy AdrianSoundy deleted the wifi_test branch June 14, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WiFiAdapter.Connect() method does not return an error when using wrong password
3 participants