Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework default base64 implementation #1946

Merged
merged 4 commits into from
Jun 7, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Now using mbedTLS version as default and for Win32 CLR.

Motivation and Context

  • The simplified default implementation was failing on some edge cases. Better play safe and use a know good one.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Now using mbedTLS version as default and for Win32 CLR.
@nfbot nfbot added the Type: bug label Jun 7, 2021
@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Jun 7, 2021
@nfbot
Copy link
Member

nfbot commented Jun 7, 2021

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click Eclo#86, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

@josesimoes josesimoes force-pushed the rework-default-base64 branch from a1fcbc0 to 4804e1a Compare June 7, 2021 13:38
@josesimoes josesimoes merged commit 6c60915 into nanoframework:develop Jun 7, 2021
@josesimoes josesimoes deleted the rework-default-base64 branch June 7, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants