Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore FindTypeDef code for reflection types #1942

Merged
merged 2 commits into from
Jun 2, 2021
Merged

Restore FindTypeDef code for reflection types #1942

merged 2 commits into from
Jun 2, 2021

Conversation

edleno2
Copy link
Contributor

@edleno2 edleno2 commented Jun 2, 2021 •
edited by josesimoes
Loading

Description

  • Uncommented the method FindTypeDef that handles reflection type defs (arrays and sub-classes)
  • Tested all CoreLibrary tests. Commented method was on a list in 2018 to find out why it was commented out, but no changes were made. After reviewing the code, comparing to .net core behavior, and extending unit test it appears the code was correct and complete.

Motivation and Context

How Has This Been Tested?

Running all CoreLibrary unit tests on Win32

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@edleno2 edleno2 marked this pull request as ready for review June 2, 2021 21:29
@josesimoes josesimoes added the Area: Interpreter Everything related with the interpreter, execution engine and such label Jun 2, 2021
@josesimoes josesimoes merged commit 4befd3b into nanoframework:develop Jun 2, 2021
josesimoes
josesimoes reviewed Jun 2, 2021
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes left review comments

Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests failing for CoreLibrary: all ValueArrayTypes tests
3 participants
@edleno2 @josesimoes @nfbot