Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Wire Protocol #1906

Merged
merged 3 commits into from
May 7, 2021
Merged

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented May 7, 2021

Description

  • Simplification of functions.
  • Rework process state machine.
  • Rework debugger functions changing flags to improve responsiveness.
  • Rework WP receiver thread on all platforms to make it more responsive.
  • Rework HAL interface on all platforms to make it more robust.

REQUIRES nf-debugger v2.0.0 and VS 2017.6.0/2019.6.0

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Simplification of functions.
- Rework process state machine.
- Rework debugger functions changing flags to improve responsiveness.
- Rework WP receiver thread on all platforms to make it more responsive.
- Rework HAL interface on all platforms to make it more robust.
@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label May 7, 2021
@nfbot
Copy link
Member

nfbot commented May 7, 2021

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click Eclo#81, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

nfbot and others added 2 commits May 7, 2021 16:03
@josesimoes josesimoes merged commit 445e3d8 into nanoframework:develop May 7, 2021
@josesimoes josesimoes deleted the update-wire-protocol branch May 7, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Breaking-change Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants