Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NXP targets to override all lwIP settings #1886

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Allow NXP targets to override all lwIP settings #1886

merged 4 commits into from
Apr 20, 2021

Conversation

MateuszKlatecki
Copy link
Member

@MateuszKlatecki MateuszKlatecki commented Apr 20, 2021

Description

  • Allow FreeRTOS targets to override all lwIP settings.

Motivation and Context

Allow end developer freedom to configure lwIP

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Apr 20, 2021

@MateuszKlatecki there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See https://github.com/MateuszKlatecki/nf-interpreter/pull/1.

Make sure you are using the project code style. Check the details here.

MateuszKlatecki and others added 2 commits April 20, 2021 12:57
…c41-9fcf-4511-a359-0baaf4dcaed2

Code style fixes for nanoframework/nf-interpreter PR#1886
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes perfect sense!
And the #ifdef checks where wrongly removed in #1885. They belong here.

@josesimoes josesimoes changed the title Allow targets to override all lwIP settings Allow NXP targets to override all lwIP settings Apr 20, 2021
@josesimoes josesimoes added the Series: NXP i6 Everything related specifically with NXP targets label Apr 20, 2021
@josesimoes josesimoes merged commit ebf3323 into nanoframework:develop Apr 20, 2021
@josesimoes josesimoes added Platform: NXP Everything related specifically with FreeRTOS and removed Series: NXP i6 Everything related specifically with NXP targets labels Apr 20, 2021
@MateuszKlatecki MateuszKlatecki deleted the patch-1 branch April 20, 2021 13:24
josesimoes pushed a commit that referenced this pull request May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: NXP Everything related specifically with FreeRTOS Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants