-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix potential memory leak in System.IO #1875
Merged
josesimoes
merged 10 commits into
nanoframework:develop
from
morali:storage_io_memory_leak
Apr 6, 2021
Merged
Fix potential memory leak in System.IO #1875
josesimoes
merged 10 commits into
nanoframework:develop
from
morali:storage_io_memory_leak
Apr 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated fixes for code style.
…de6-0d8a-4b34-a959-9605400ce268 Code style fixes for nanoframework/nf-interpreter PR#1875
Automated fixes for code style.
…09f-840f-45fa-bed9-f3acdd33c3e0 Code style fixes for nanoframework/nf-interpreter PR#1875
Automated fixes for code style.
…801-35a4-40eb-97c5-609a82603f13 Code style fixes for nanoframework/nf-interpreter PR#1875
josesimoes
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thanks for taking care of this. 👏🏻 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New implementation of System.IO allocates memory and frees it only if fatfs methods return without error. This can lead to memory leak, if for example f_open method fails. I added CLEANUP() sections in native methods for freeing memory allocated on heap and closing file handles.
Motivation and Context
Fixes memory leak in System.IO
How Has This Been Tested?
Screenshots
Types of changes
Checklist: