-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes wrong number or read/written bytes for System.Device.I2c #1819
Conversation
Fixed dead link
@RolandoMagico I've fixed the checklist for you. |
Hey @RolandoMagico ! First of all: thank you for looking into this. 👍🏻 Please use separate PRs to address each issue: one for the wrong link and another for fixing the SpanByte issue with I2C. |
@RolandoMagico it would be awesome if you could replicate the fix to the STM32 implementation... 😉 |
...MSIS-OS/ChibiOS/nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp
Outdated
Show resolved
Hide resolved
...MSIS-OS/ChibiOS/nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp
Outdated
Show resolved
Hide resolved
.../ESP32_WROOM_32/nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp
Outdated
Show resolved
Hide resolved
.../ESP32_WROOM_32/nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp
Outdated
Show resolved
Hide resolved
.../ESP32_WROOM_32/nanoCLR/System.Device.I2c/sys_dev_i2c_native_System_Device_I2c_I2cDevice.cpp
Outdated
Show resolved
Hide resolved
Ignoring build failure for ChibiOS based targets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Motivation and Context
How Has This Been Tested?
Not yet tested
Screenshots
Types of changes
Checklist: