-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Flush fix plus extra SPI displays #1788
Conversation
Hi @AdrianSoundy, nI'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
Hi @AdrianSoundy, 😞 You have to make up your mind on how this PR addresses the issue. It either fixes, closes or resolves it. Can't have them all... |
Automated fixes for code style.
@AdrianSoundy there are issues with the code style on the source files. Make sure you are using the project code style. Check the details here. |
…3-7dbb-4855-adf7-46061a013be0' into ui-fixes
…t-fix/875c8a43-7dbb-4855-adf7-46061a013be0"
@AdrianSoundy there are issues with the code style on the source files. Make sure you are using the project code style. Check the details here. |
…ng-format-fix/875c8a43-7dbb-4855-adf7-46061a013be0"" This reverts commit 361d59e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the rest LGTM!
src/nanoFramework.Graphics/Graphics/Displays/Spi_To_Display.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Changes to the BitBlt method to enable it to work with a window in the bitmap.
Tidied up some code.
Also added initial drivers for SPI displays SSD1331(colour) and SSD1306(mono)
These displays only require a small frame buffer so they can work on an ESP32 without spiram. The SSD1306 also comes in I2C version but held back I2C driver as that requires other changes to share bus and have a generic I2C interface for all platforms.
Motivation and Context
How Has This Been Tested?
Tested using small test program that displayed partial parts of complete screen and also tested with Tetris sample for larger screens( to be updated)
Following combinations tested
Types of changes
Checklist: