Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of WeakReference #1741

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Type system was missing the class definition for the type.
  • GetTarget was using a simplified version of the code that wasn't taking into account the possibility of serialized content.

Motivation and Context

How Has This Been Tested?

  • Using test project from issue.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Type system was missing the class definition for the type.
- GetTarget was using a simplified version of the code that wasn't taking into account the possibility of serialized content.
@nfbot
Copy link
Member

nfbot commented Oct 21, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Interpreter Everything related with the interpreter, execution engine and such hacktoberfest-accepted labels Oct 21, 2020
@josesimoes josesimoes merged commit cb52d57 into nanoframework:develop Oct 21, 2020
@josesimoes josesimoes deleted the fix-652 branch October 21, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such hacktoberfest-accepted Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WeakReference crashes firmware
2 participants