Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on GPIO layer for TI SimpleLink #1697

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Remove reserved pins array.
  • Rework code to use GPIO pin config array for this purpose.
  • Rework code in some functions to follow the separation of concerns principle.
  • Fix error preventing using pins higher than 15.
  • Add gpio config file at target level.

Motivation and Context

  • Reserved pins array was a duplicated of the pin config array.
  • TI SimpleLink design doesn't follow the port&pin pattern, there are only GPIO pins. The existing code was based on that, so it had to be improved.
  • Some rework required to follow the separation of concerns principle.

How Has This Been Tested?

  • GPIO+events sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Remove reserved pins array.
- Rework code to use GPIO pin config array for this purpose.
- Rework code in some functions to follow the separation of concerns principle.
- Fix error preventing using pins higher than 15.
- Add gpio config file at target level.
@nfbot
Copy link
Member

nfbot commented Sep 9, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot
Copy link
Member

nfbot commented Sep 9, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#33.

Make sure you are using the project code style. Check the details here.

Automated fixes for code style.
@josesimoes josesimoes merged commit 766bee8 into nanoframework:develop Sep 9, 2020
@josesimoes josesimoes deleted the work-ti-gpio branch September 9, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants