Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work wireless config ESP32 #1652

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jun 3, 2020

Description

  • Update system.net declaration to use generated enums.
  • Rework code accordingly.
  • Rename Flags to Options on wireless config HAL structs to match managed class.
  • Rework code to to use new enum options to disable wireless station and AP.
  • Minor changes to code style.

Motivation and Context

  • Fixes storing/retrieving ESP32 config blocks.
  • Sync enums in System.Net between managed and native.

How Has This Been Tested?

  • Running SSL sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Update system.net declaration to use generated enums.
- Rework code accordingly.
- Rename Flags to Options on wireless config HAL structs to match managed class.
- Rework code to to use new enum options to disable wireless station and AP.
- Minor changes to code style.

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes merged commit 2e59b8c into nanoframework:develop Jun 3, 2020
@josesimoes josesimoes deleted the work-wirelessconfig-esp32 branch June 3, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants