Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on GPIO code #1598

Merged
merged 6 commits into from
Apr 2, 2020
Merged

Work on GPIO code #1598

merged 6 commits into from
Apr 2, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Fix code accessing the debounce field because it's a TimeSpan type.
  • GpioController has the same code on all platforms, moved it upwards to the GPIO common folder.
  • GpioPin has the same code on all platforms, moved it upwards to the GPIO common folder.
  • Replace calls to malloc and free with platform ones.
  • Rework declaration of CPU_GPIO functions by replacing parameter type to use CLR type and case changes to follow coding style.
  • Update declaration of GPIO assembly in Win CLR32.

Motivation and Context

How Has This Been Tested?

  • Gpio+Events sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes added Type: bug Area: Targets Area: Common libs Everything related with common libraries labels Apr 1, 2020
@nfbot
Copy link
Member

nfbot commented Apr 1, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Remove duplicated GpioController code files
7723032 
- GpioController has the same code on all platforms, moved it upwards to the GPIO common folder.

Signed-off-by: josesimoes <[email protected]>
@josesimoes
Remove duplicated GpioPin code files
c3ee050 
- GpioPin has the same code on all platforms, moved it upwards to the GPIO common folder.

Signed-off-by: josesimoes <[email protected]>
@josesimoes
Replace calls to malloc and free with platform ones
88520de 
Signed-off-by: josesimoes <[email protected]>
@josesimoes
Rework declaration of CPU_GPIO functions
8cc6211 
- Replace parameter type to use CLR type.
- Case changes to follow coding style.

Signed-off-by: josesimoes <[email protected]>
@josesimoes
Update declaration of GPIO assembly in Win CLR32
6402168 
Signed-off-by: josesimoes <[email protected]>
@josesimoes
Rework debounce timeout code
f8e2979 
- Fix code accessing this field.
- Update declaration of Devices.Gpio assembly.

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes added Series: NXP i6 Everything related specifically with NXP targets Series: STM32xx Everything related specifically with STM32 targets Series: TI-CC13x2_26x2 Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds and removed Area: Targets labels Apr 2, 2020
@josesimoes josesimoes merged commit 62bdeaf into nanoframework:develop Apr 2, 2020
@josesimoes josesimoes deleted the work-gpio branch April 9, 2020 15:48
@josesimoes josesimoes mentioned this pull request Apr 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Series: NXP i6 Everything related specifically with NXP targets Series: STM32xx Everything related specifically with STM32 targets Series: TI-CC13x2_26x2 Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gpio interrupts have stopped working for ESP32 (and STM32?)
2 participants
@josesimoes @nfbot