Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STM32 CRC32 driver #1585

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Fix CRC32 calculation for STM32L0-F7-H7.
  • Remove code to handle input data formats other than bytes.

Motivation and Context

  • The existing code was failing when buffer size is not multiple of 4.
  • Code clean-up: no need to have there code to handle formats that are not used.

How Has This Been Tested?

  • Debugger WPF test app.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@nfbot
Copy link
Member

nfbot commented Mar 12, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: bug labels Mar 12, 2020
- Fix CRC32 calculation for STM32L0-F7-H7. Was failing when buffer size is not multiple of 4.
- Remove code to handle input data formats other than bytes.

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes merged commit 65357c3 into nanoframework:develop Mar 12, 2020
@josesimoes josesimoes deleted the fix-stm32-crc32 branch March 12, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants