Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in CRC32 calculation #1584

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Improvements in CRC32 calculation #1584

merged 1 commit into from
Mar 12, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Mar 12, 2020 •
edited
Loading

Description

  • Rework declaration of SUPPORT_ComputeCRC to declare parameters as constants.
  • Rework code accordingly.

Motivation and Context

  • Makes clearer the parameters usage to help the linker to improve optimizations.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@nfbot
Copy link
Member

nfbot commented Mar 12, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Series: STM32xx Everything related specifically with STM32 targets Platform: TI-SimpleLink Type: enhancement labels Mar 12, 2020
@josesimoes
Improvements in CRC32 calculation
24acaf1 
- Rework declaration of SUPPORT_ComputeCRC to declare parameters as constants.
- Rework code accordingly.

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes force-pushed the improve-crc-declarations branch from 60d222b to 24acaf1 Compare March 12, 2020 15:02
@josesimoes josesimoes merged commit 504ebdb into nanoframework:develop Mar 12, 2020
@josesimoes josesimoes deleted the improve-crc-declarations branch March 12, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Platform: TI-SimpleLink Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot