Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AccessMemoryErrorCodes enum #1575

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Replace enum value from 0 to 1.

Motivation and Context

  • Can't use a 0 value here because the enum is loaded into a variable that is used in Wire Protocol. Because of this (and only when LTO linking option is enable) the optimizations this considered as a NULL and that causes a stall in the transmit message code.
  • Addresses Error erasing deployment area Home#578

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

- Can't use `0` here.
@josesimoes josesimoes added Area: Common libs Everything related with common libraries Breaking-change labels Mar 5, 2020
@nfbot
Copy link
Member

nfbot commented Mar 5, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to nanoframework/nf-debugger that referenced this pull request Mar 5, 2020
@josesimoes josesimoes merged commit 6d85005 into develop Mar 5, 2020
@josesimoes josesimoes deleted the josesimoes-patch-2 branch March 5, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants