Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WP header verification when CRC32 is not implemented #1550

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Fix WP header verification when CRC32 is not implemented #1550

merged 1 commit into from
Feb 11, 2020

Conversation

antoniofagundes
Copy link
Member

Description

  • Move code and vars to inside compiler define.
  • Rename var for clarity.

Motivation and Context

  • This code bit is only necessary when WP implements CRC32, therefore the compiler will issue a warning about a not used var.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Antonio Fagundes[email protected]

@nfbot
Copy link
Member

nfbot commented Feb 11, 2020

Hi @antoniofagundes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: bug labels Feb 11, 2020
josesimoes
josesimoes approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit d0515b8 into nanoframework:develop Feb 11, 2020
@antoniofagundes antoniofagundes deleted the patch-2 branch February 11, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoniofagundes @nfbot @josesimoes