Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gpio drivemode validation failed on ESP32 #1546

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Gpio drivemode validation failed on ESP32 #1546

merged 1 commit into from
Feb 5, 2020

Conversation

AdrianSoundy
Copy link
Member

The drivemode mode validation was incorrect for GPIO input pins.

Fixes error reported on Discord

How Has This Been Tested?

var pin = _gpioController.OpenPin(23);
pin.SetDriveMode(GpioPinDriveMode.InputPullUp);
pin.ValueChanged += Pin_ValueChanged;

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy [email protected]

@AdrianSoundy AdrianSoundy added Status: DONE Series: ESP32 Everything related specifically with ESP32 series targets labels Feb 5, 2020
@nfbot
Copy link
Member

nfbot commented Feb 5, 2020

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy merged commit c11b33a into nanoframework:develop Feb 5, 2020
@AdrianSoundy AdrianSoundy deleted the gpioTest branch February 5, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants