Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing updated sdkconfig.h for IDF 3.3 #1510

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Missing updated sdkconfig.h for IDF 3.3 #1510

merged 1 commit into from
Nov 23, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

The LWIP was missing the feature for LWIP_SO_RCVBUF in the current build due to using an older version of sdkconfig.h from the IDF 3.3 library build.
`

Motivation and Context

How Has This Been Tested?

With provided sample.
After fixing exception found the test still didn't work. The read stream timed out and there was no data. Found that the HttpWebResponse had a stream with 2 bytes but the stream read wasn't working.

Noticed in sample that it was getting the response again.
So changed it and it worked

var httpResponse = (HttpWebResponse)httpWebRequest.GetResponse();
                using (var stream = httpWebRequest.GetResponse().GetResponseStream())

to

 var httpResponse = (HttpWebResponse)httpWebRequest.GetResponse();
               using (var stream = httpResponse.GetResponseStream())

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy [email protected]

@nfbot
Copy link
Member

nfbot commented Nov 23, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks like you've found other tweaks that were in order. 👍

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Type: bug labels Nov 23, 2019
@josesimoes josesimoes merged commit e4e1d09 into nanoframework:develop Nov 23, 2019
@AdrianSoundy AdrianSoundy deleted the webrequest branch November 23, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP WebRequest throws SocketException
3 participants