Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on SSL accept #1502

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Work on SSL accept #1502

merged 1 commit into from
Nov 13, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Fix implementation of accept internal.
  • Fix setting of minor and major TLS protocol version.

Motivation and Context

How Has This Been Tested?

  • HTTP listener sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets labels Nov 12, 2019
@nfbot
Copy link
Member

nfbot commented Nov 12, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Fix implementation of accept internal.
- Fix setting of minor and major TLS protocol version.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes closed this Nov 13, 2019
@josesimoes josesimoes deleted the fix-520 branch November 13, 2019 01:15
@josesimoes josesimoes restored the fix-520 branch November 13, 2019 02:05
@josesimoes josesimoes reopened this Nov 13, 2019
@josesimoes josesimoes merged commit c1e3073 into nanoframework:develop Nov 13, 2019
@josesimoes josesimoes deleted the fix-520 branch November 13, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpListener.GetContext() fails when listening on HTTPS (throws SocketException)
2 participants