Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for SRAM #1460

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Fix support for SRAM #1460

merged 1 commit into from
Oct 22, 2019

Conversation

martin-kuhn
Copy link
Contributor

@martin-kuhn martin-kuhn commented Oct 22, 2019

Description

This fixes an issue if someone wants to use FSMC with a external SRAM.

Motivation and Context

An external memory like a NOR Flash or PSRAM can be connected using the onboard FSMC and the SRAM driver provided by the nf-overlay. The actual code in targets/CMSIS-OS/ChibiOS/nanoCLR/targetHAL_Power.c does only support SDRAM. If someone uses the SRAM driver instead of the SDRAM driver, this causes an error.

How Has This Been Tested?

I am using an external PSRAM on my board which is connected with the SRAMD2 driver, which works fine with the above fix.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This fixes an issue if someone uses FSMC but SRAM instead of SDRAM.
@nfbot
Copy link
Member

nfbot commented Oct 22, 2019

Hi @martin-kuhn,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2019

CLA assistant check
All committers have signed the CLA.

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: bug labels Oct 22, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for providing this fix. 👍

@josesimoes josesimoes merged commit bc8c607 into nanoframework:develop Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants