Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in Monitor_FlashSectorMap #1447

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Improvements in Monitor_FlashSectorMap #1447

merged 2 commits into from
Sep 19, 2019

Conversation

antoniofagundes
Copy link
Member

Description

  • Change workflow to remove repeated calls and improve efficiency.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: António Fagundes[email protected]

@antoniofagundes
Improvements in Monitor_FlashSectorMap
2783cbe 
- Change workflow to remove repeated calls and improve efficiency.
@nfbot
Copy link
Member

nfbot commented Sep 19, 2019

Hi @antoniofagundes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: enhancement labels Sep 19, 2019
josesimoes
josesimoes approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes merged commit c8b01c1 into nanoframework:develop Sep 19, 2019
@josesimoes josesimoes deleted the improve-Monitor_FlashSectorMap branch September 19, 2019 17:00
morali pushed a commit to morali/nf-interpreter that referenced this pull request Oct 4, 2019
@antoniofagundes @MateuszKlatecki
Improvements in Monitor_FlashSectorMap (nanoframework#1447)
6bb9729 
***NO_CI***

(cherry picked from commit c8b01c1)
@coderabbitai coderabbitai bot mentioned this pull request Aug 13, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoniofagundes @nfbot @josesimoes