Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetInvocationList to System.Delegate #1400

Merged
merged 3 commits into from
Jul 10, 2019
Merged

Add GetInvocationList to System.Delegate #1400

merged 3 commits into from
Jul 10, 2019

Conversation

MateuszKlatecki
Copy link
Member

@MateuszKlatecki MateuszKlatecki commented Jul 10, 2019

Description

  • Added method GetInvocationList to System.Delegate.
  • Update corlib assembly declaration.

Motivation and Context

How Has This Been Tested?

Tested with following code

   public delegate void TestEventHandler();

    public class Program
    {
        public static event TestEventHandler OnTest;

        static void ListMethods(TestEventHandler handler)
        {
            var delegates = handler.GetInvocationList();

            Console.WriteLine("Delegates: " + delegates.Length);
            foreach (var d in delegates)
            {
                Console.WriteLine("Method: " + d.Method.Name);
            }
        }

        public static void Method1()
        {
            Console.WriteLine("Method 1");
        }

        public static void Method2()
        {
            Console.WriteLine("Method 2");
        }

        public static void Method3()
        {
            Console.WriteLine("Method 3");
        }

        public static void Main()
        {

            Console.WriteLine("-= Test one delegate =-");
            OnTest += Method1;
            ListMethods(OnTest);

            Console.WriteLine("-= Test two delegates -=");
            OnTest += Method2;
            ListMethods(OnTest);

            Console.WriteLine("-= Test three delegates =-");
            OnTest += Method3;
            ListMethods(OnTest);

            Console.WriteLine("-= Test remove one delegate =-");
            OnTest -= Method2;
            ListMethods(OnTest);

            Console.WriteLine("-= Test anonymous delegate =-");
            OnTest += () => { Console.WriteLine("Anonymous"); };
            ListMethods(OnTest);

            Console.WriteLine("-= Invoke =-");
            OnTest?.Invoke(); 

        }
        
    }

Output

-= Test one delegate =-
Delegates: 1
Method: Method1
-= Test two delegates -=
Delegates: 2
Method: Method1
Method: Method2
-= Test three delegates =-
Delegates: 3
Method: Method1
Method: Method2
Method: Method3
-= Test remove one delegate =-
Delegates: 2
Method: Method1
Method: Method3
-= Test anonymous delegate =-
Delegates: 3
Method: Method1
Method: Method3
Method: <Main>b__7_0
-= Invoke =-
Method 1
Method 3
Anonymous

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Mateusz Klatecki [email protected]

@nfbot
Copy link
Member

nfbot commented Jul 10, 2019

Hi @MateuszKlatecki,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: enhancement labels Jul 10, 2019
@josesimoes josesimoes changed the title Delagate.GetInvocationList Add GetInvocationList to System.Delegate Jul 10, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!! 💯 👏

@josesimoes josesimoes merged commit a3391ac into nanoframework:develop Jul 10, 2019
@MateuszKlatecki MateuszKlatecki deleted the Delagate.GetInvocationList branch July 11, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Delegate allow to get InvocationList
3 participants