Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Monitor_ReadMemory command #1337

Merged
merged 1 commit into from
May 28, 2019
Merged

Fix Monitor_ReadMemory command #1337

merged 1 commit into from
May 28, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add ErrorCode to Monitor_ReadMemory::Reply.
  • Fix implementation of Monitor_ReadMemory to use error code and buffer from heap instead of local var.
  • Update CheckPermissions to allow reading BOOTSTRAP and CODE block ranges.
  • Update comment to AccessMemoryErrorCodes to link back to managed code.

Motivation and Context

  • Read memory command wasn't working.
  • Also needed it to allow read access to CLR and booter in order to improve the deployment features in debugger library.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Fix Monitor_ReadMemory command
b1ddf2d 
- Add ErrorCode to Monitor_ReadMemory::Reply.
- Fix implementation of Monitor_ReadMemory to use error code and buffer from heap instead of local var.
- Update CheckPermissions to allow reading BOOTSTRAP and CODE block ranges.
- Update comment to AccessMemoryErrorCodes to link back to managed code.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries Breaking-change labels May 28, 2019
@nfbot
Copy link
Member

nfbot commented May 28, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 9e80bdc into nanoframework:develop May 28, 2019
@josesimoes josesimoes deleted the fix-read-memory branch May 28, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Breaking-change Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot