-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Support for Windows.Storage on Esp32 #1286
Merged
josesimoes
merged 11 commits into
nanoframework:develop
from
AdrianSoundy:Storage-esp32
Apr 18, 2019
Merged
Initial Support for Windows.Storage on Esp32 #1286
josesimoes
merged 11 commits into
nanoframework:develop
from
AdrianSoundy:Storage-esp32
Apr 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @AdrianSoundy, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
Fixed typo in keyword
- Add missing implementation of GetInternalStorageFoldersNative.
josesimoes
requested changes
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed a couple of issues on ChibiOS/STM32 that were preventing the build.
Please look at the others that I've commented.
josesimoes
approved these changes
Apr 17, 2019
josesimoes
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Series: ESP32
Everything related specifically with ESP32 series targets
Series: STM32xx
Everything related specifically with STM32 targets
Type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created versions of Windows.Storage that use the ESP32 IDF - VFS(virtual file system)
Added extra methods to allow the SDcard devices to be mounted from managed code
Currently supports 1 device MMC(4 bit or 1 bit) or SPI
Doesn't look like ESP32 IDF has support for Card present events or not in example code.
Currently working on the SDCard being in slot from boot and the card is mounted from managed code.
Motivation and Context
Needed to be implemented
Testing
Tested with following ESP32 devices:-
ESP DevKitC - SPI
ESP32 Wrover v4 - MMC 4 bit
ESP32 Olimex EVB - MMC 1 bit
Types of changes
Checklist:
Signed-off-by: adriansoundy [email protected]