Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Support for Windows.Storage on Esp32 #1286

Merged
merged 11 commits into from
Apr 18, 2019
Merged

Initial Support for Windows.Storage on Esp32 #1286

merged 11 commits into from
Apr 18, 2019

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Apr 17, 2019

Description

Created versions of Windows.Storage that use the ESP32 IDF - VFS(virtual file system)
Added extra methods to allow the SDcard devices to be mounted from managed code
Currently supports 1 device MMC(4 bit or 1 bit) or SPI

Doesn't look like ESP32 IDF has support for Card present events or not in example code.
Currently working on the SDCard being in slot from boot and the card is mounted from managed code.

Motivation and Context

Needed to be implemented

Testing

Tested with following ESP32 devices:-

ESP DevKitC - SPI
ESP32 Wrover v4 - MMC 4 bit
ESP32 Olimex EVB - MMC 1 bit

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy [email protected]

@nfbot
Copy link
Member

nfbot commented Apr 17, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement labels Apr 17, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed a couple of issues on ChibiOS/STM32 that were preventing the build.
Please look at the others that I've commented.

@josesimoes josesimoes merged commit c24d5b8 into nanoframework:develop Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants