Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for platform delay in CLR code #1264

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add support for platform delay in CLR code.
  • Add implementation of PLATFORM_DELAY for STM32 and ESP32 platforms.

Motivation and Context

  • There are places in the CLR code (which has to be kept platform independent) that require a delay on the execution. Providing this call implemented at platform level makes that possible.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Area: Common libs Everything related with common libraries labels Mar 15, 2019
@nfbot
Copy link
Member

nfbot commented Mar 15, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 49ffffb into nanoframework:develop Mar 15, 2019
@josesimoes josesimoes deleted the add-platform-delay branch March 15, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants