Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements on goto sleep workflow #1158

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Improvements on goto sleep workflow #1158

merged 1 commit into from
Jan 21, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Update native declaration for STM32.
  • Remove call to CLR_E_THREAD_WAITING in ESP32 handler.
  • Add developer notes with detailed explanation on the expected workflow.

Motivation and Context

  • Fixes issues with going into deep sleep mode.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets labels Jan 21, 2019
@nfbot
Copy link
Member

nfbot commented Jan 21, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Improvements on goto sleep workflow
1f29f78 
- Update native declaration for STM32.
- Remove call to CLR_E_THREAD_WAITING in ESP32 handler.
- Add developer notes with detailed explanation on the expected workflow.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes force-pushed the improvements-goto-sleep branch from 1e434bf to 1f29f78 Compare January 21, 2019 18:05
@josesimoes josesimoes merged commit 1ee2ebd into nanoframework:develop Jan 21, 2019
@josesimoes josesimoes deleted the improvements-goto-sleep branch January 21, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot