Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of X509 certificate for mbedTLS #1092

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Remove hack forcing an extra byte length for terminator. This has to be properly handled by the caller.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@nfbot
Copy link
Member

nfbot commented Dec 12, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the fix-x509certificate-parsing branch from eb6609c to 08c5476 Compare December 12, 2018 11:41
@josesimoes josesimoes merged commit 539e560 into nanoframework:develop Dec 12, 2018
@josesimoes josesimoes deleted the fix-x509certificate-parsing branch December 12, 2018 12:38
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants