Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ADC NativeInit #1081

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Fix ADC NativeInit #1081

merged 1 commit into from
Dec 3, 2018

Conversation

josesimoes
Copy link
Member

Description

Motivation and Context

  • The code was using an older version which passed an argument with index. Which is wrong for a while now.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

- The code was still using an older version which passed an argument with index. Which is wrong for a while now.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets labels Dec 3, 2018
@nfbot
Copy link
Member

nfbot commented Dec 3, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Fix Adc NativeInit Fix ADC NativeInit Dec 3, 2018
@josesimoes josesimoes merged commit 8a4d549 into nanoframework:develop Dec 3, 2018
@josesimoes josesimoes deleted the fix-adc-init branch December 3, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants